➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
标题: weakref copy module interaction
类型: behavior Stage: patch review
Components: Library (Lib) Versions: Python 3.1, Python 2.7
process
状态: closed Resolution: fixed
Dependencies: 后续:
分配给: 抄送列表: gvanrossum, jafo, pitrou, rharris, rhettinger, tim.peters
优先级: normal 关键字: patch

Created on 2008-02-14 21:22 by rharris, last changed 2022-04-11 14:56 by admin. This issue is now closed.

文件
文件名 上传时间 Description 编辑
copy.patch rharris, 2008-02-14 21:22 Possible patch to fix this
issue2116.patch pitrou, 2009-03-15 00:34
issue2116-2.patch pitrou, 2009-03-15 00:45
Messages (9)
msg62413 - (view) Author: Rick Harris (rharris) 日期: 2008-02-14 21:22
The copy module will not properly copy/deepcopy weakrefs, it will bomb
out with __new__ not having enough args. This is a problem b/c it makes
deepcopying of objects that make use of Weak(Key|Value)Dictionaries
difficult.

To replicate:

import copy, weakref
class Test(object): pass
t = Test()
wr = weakref.ref(t)
wr_new = copy.copy(wr)
msg64101 - (view) Author: Sean Reifschneider (jafo) * (Python committer) 日期: 2008-03-19 21:12
Rick: In the future, please provide a context or unified diff ("diff
-c") so that we get the file name that the diff is for and some
additional context.
msg64909 - (view) Author: Rick Harris (rharris) 日期: 2008-04-04 01:06
Sorry about forgetting the -c arg! The patch is intended for
python/trunk/Lib/copy.py.

It looks like Raymond Hettinger has made a similar-ish change recently
to make Ellipsis copyable.
msg83606 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) 日期: 2009-03-14 23:49
Should a deepcopy of a weakref return the same weakref, or a weakref to
a new copied object?
Also, what about the optional callback?
msg83607 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) 日期: 2009-03-14 23:53
Hmm, forget that question. If we deepcopy the weakref target, it will be
destroyed just afterwards, making the deepcopied weakref useless.
msg83609 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) 日期: 2009-03-15 00:34
Here is a patch providing proper copy and deepcopy support, including
for weak dicts (the Proxy type is unsupported, though).
msg83612 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) 日期: 2009-03-15 00:45
Updated patch so that copied weakdicts are decoupled (adding an item to
the copy doesn't mutate the original).
msg86917 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) 日期: 2009-05-01 21:48
Raymond, Guido, any opinion on this one?
msg87822 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) 日期: 2009-05-15 17:06
Committed in r72662, r72670. Thanks!
历史
日期 用户 动作 参数
2022-04-11 14:56:30admin修改github: 46370
2009-05-15 17:06:04pitrou修改状态: open -> closed
resolution: fixed
消息: + msg87822
2009-05-01 21:48:34pitrou修改versions: + Python 3.1, Python 2.7, - Python 2.5
抄送: + gvanrossum, rhettinger

消息: + msg86917

assignee: tim.peters ->
stage: patch review
2009-03-15 00:45:18pitrou修改文件: + issue2116-2.patch

消息: + msg83612
2009-03-15 00:34:32pitrou修改文件: + issue2116.patch

消息: + msg83609
2009-03-14 23:53:07pitrou修改消息: + msg83607
2009-03-14 23:49:09pitrou修改抄送: + pitrou
消息: + msg83606
2008-04-04 01:06:50rharris修改消息: + msg64909
2008-03-19 21:12:13jafo修改抄送: + jafo, tim.peters
消息: + msg64101
优先级: normal
assignee: tim.peters
keywords: + patch
type: crash -> behavior
2008-02-14 21:22:34rharris创建