消息 [80248]
Comments on the patch:
- you should check the error return of lseek() (and possibly wrap it in
Py_BEGIN/END_ALLOW_THREADS, see portable_lseek() in the same file)
- there should be a test for each of unbuffered IO (buffering=0),
buffered IO ("rb") and text IO ("r"). For text IO, the test shouldn't
test the actual value returned by tell(), only that it is > 0 (because
tell() in text mode is an opaque value and is not necessarily equal to a
byte position) |
|
| 日期 |
用户 |
动作 |
参数 |
| 2009-01-20 11:40:46 | pitrou | 修改 | recipients:
+ pitrou, vstinner |
| 2009-01-20 11:40:45 | pitrou | 修改 | messageid: <1232451645.89.0.19220507025.issue5008@psf.upfronthosting.co.za> |
| 2009-01-20 11:40:45 | pitrou | 链接 | issue5008 messages |
| 2009-01-20 11:40:32 | pitrou | 创建 | |
|