Skip to content

Backport set literals #46588

Closed
Closed

Description

@brettcannon
BPO 2335
Nosy @gvanrossum, @brettcannon, @rhettinger, @avassalotti, @benjaminp
Files
  • backport_set_literal.diff
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2010-01-09.23:37:29.239>
    created_at = <Date 2008-03-17.17:38:45.776>
    labels = ['interpreter-core', 'type-bug']
    title = 'Backport set literals'
    updated_at = <Date 2010-01-09.23:37:29.238>
    user = 'https://github.com/brettcannon'

    bugs.python.org fields:

    activity = <Date 2010-01-09.23:37:29.238>
    actor = 'alexandre.vassalotti'
    assignee = 'none'
    closed = True
    closed_date = <Date 2010-01-09.23:37:29.239>
    closer = 'alexandre.vassalotti'
    components = ['Interpreter Core']
    creation = <Date 2008-03-17.17:38:45.776>
    creator = 'brett.cannon'
    dependencies = []
    files = ['14650']
    hgrepos = []
    issue_num = 2335
    keywords = ['patch', '26backport']
    message_count = 9.0
    messages = ['63692', '70455', '91279', '91280', '91284', '91289', '91294', '96256', '97478']
    nosy_count = 5.0
    nosy_names = ['gvanrossum', 'brett.cannon', 'rhettinger', 'alexandre.vassalotti', 'benjamin.peterson']
    pr_nums = []
    priority = 'normal'
    resolution = 'accepted'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue2335'
    versions = ['Python 2.7']

    Activity

    1. brettcannon commented on Mar 17, 2008

      @brettcannon
      MemberAuthor

      Set literals need to be backported.

    2. benjaminp commented on Jul 31, 2008

      @benjaminp
      Contributor

      I'm going to defer this to 2.7.

    3. avassalotti commented on Aug 4, 2009

      @avassalotti
      Member

      Here is a patch for backporting set literals to the trunk.

    4. rhettinger commented on Aug 4, 2009

      @rhettinger
      Contributor

      Guido, I thought you had decided for this to just be a 3.x feature.

      Alex, if this goes forward, were you also going to change the repr() for
      sets and the corresponding pprint code? Are set comprehensions on the
      radar screen also. IMO, these all go hand in hand.

    5. avassalotti commented on Aug 4, 2009

      @avassalotti
      Member

      I think we should keep the repr() of sets as is to avoid breaking any
      code. And yes, I plan to port set comprehensions along with dict
      comprehension.

    6. gvanrossum commented on Aug 5, 2009

      @gvanrossum
      Member

      Raymond, I know you see this differently, but personally I don't see a
      problem with 2.7 getting additional backports of 3.x features, as long
      as they are backwards compatible. While personally I wouldn't spend
      effort on this particular backport, I don't see a problem when someone
      volunteers a patch. In this specific case, I am fine with accepting set
      literals and set comprehensions as new syntax. I do agree that repr()
      needs to be kept the same as it was under 2.6.

    7. removed their assignment
      on Aug 5, 2009
    8. rhettinger commented on Aug 5, 2009

      @rhettinger
      Contributor

      These all seem fine to me. Was just checking in because I thought you
      had previously pronounced otherwise.

    9. avassalotti commented on Dec 11, 2009

      @avassalotti
      Member

      If there are no objections, I will commit this patch later this week.

    10. avassalotti commented on Jan 9, 2010

      @avassalotti
      Member

      It been a long week, but this patch is now committed as r77400.

    11. transferred this issue fromon Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    No one assigned

      Labels

      interpreter-core(Objects, Python, Grammar, and Parser dirs)type-bugAn unexpected behavior, bug, or error

      Projects

      No projects

        Milestone

        No milestone

        Relationships

        None yet

        Development

        No branches or pull requests

        Issue actions