Skip to content

Python 2.6 fails to build with Py_NO_ENABLE_SHARED #48744

Closed

Description

@snaury
mannequin
BPO 4494
Nosy @loewis
Files
  • python-2.6-static.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/loewis'
    closed_at = <Date 2009-02-02.15:34:26.756>
    created_at = <Date 2008-12-02.20:46:50.065>
    labels = ['build', 'OS-windows']
    title = 'Python 2.6 fails to build with Py_NO_ENABLE_SHARED'
    updated_at = <Date 2009-02-02.15:34:26.755>
    user = 'https://bugs.python.org/snaury'

    bugs.python.org fields:

    activity = <Date 2009-02-02.15:34:26.755>
    actor = 'loewis'
    assignee = 'loewis'
    closed = True
    closed_date = <Date 2009-02-02.15:34:26.756>
    closer = 'loewis'
    components = ['Windows']
    creation = <Date 2008-12-02.20:46:50.065>
    creator = 'snaury'
    dependencies = []
    files = ['12203']
    hgrepos = []
    issue_num = 4494
    keywords = ['patch']
    message_count = 2.0
    messages = ['76778', '80942']
    nosy_count = 2.0
    nosy_names = ['loewis', 'snaury']
    pr_nums = []
    priority = 'high'
    resolution = 'accepted'
    stage = None
    status = 'closed'
    superseder = None
    type = 'compile error'
    url = 'https://bugs.python.org/issue4494'
    versions = ['Python 2.6']

    Activity

    1. snaury commented on Dec 2, 2008

      snaurymannequin
      MannequinAuthor

      When building python 2.6 with Py_NO_ENABLE_SHARED compilation fails on
      PC/getpathp.c, because it uses PyWin_DLLVersionString and
      PyWin_DLLhModule unconditionally, which are implemented in PC/dl_nt.c
      only when Py_ENABLE_SHARED is defined. The attached patch fixes the
      problem by wrapping dependent parts in if #ifdef Py_ENABLE_SHARED/#endif.

    2. self-assigned this
      on Dec 2, 2008
    3. loewis commented on Feb 2, 2009

      loewismannequin
      Mannequin

      Thanks for the patch. Committed as r69205, r69206, r69207, r69208.

    4. transferred this issue fromon Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    Labels

    OS-windowsbuildThe build process and cross-build

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions