You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee='https://github.com/birkenfeld'closed_at=<Date2008-12-24.16:27:33.070>created_at=<Date2008-12-24.14:26:08.785>labels= ['docs']
title='documentation and noddy*.c'updated_at=<Date2008-12-24.16:27:33.068>user='https://bugs.python.org/exe'
But thats not true, it's defined as PyObject*. I think this is outdated
info in documentation.
2) In Doc/includes/noddy*.c assumed that PyMODINIT_FUNC returns nothing
but this wrong. If you try "python3.1 -c 'import noddy'" you will see
segfault. This patch will fix this problem:
--- ./noddy.c 2008-12-24 17:09:36.424870738 +0300+++ ./noddy.c 2008-12-24 17:18:01.524869143 +0300@@ -52,4 +52,6 @@
Py_INCREF(&noddy_NoddyType);
PyModule_AddObject(m, "Noddy", (PyObject *)&noddy_NoddyType);
++ return m;
}
Other noddy*.c files are also requiring this patch.
Activity
exe commentedon Dec 24, 2008
Hello!
=========
Note that PyMODINIT_FUNC declares the function as void return type
=========
But thats not true, it's defined as PyObject*. I think this is outdated
info in documentation.
Other noddy*.c files are also requiring this patch.
benjaminp commentedon Dec 24, 2008
Thanks for the report! Fixed in r67925.