Skip to content

documentation and noddy*.c #48987

Closed
Closed

Description

@exe
mannequin
BPO 4737
Nosy @birkenfeld, @benjaminp

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = 'https://github.com/birkenfeld'
closed_at = <Date 2008-12-24.16:27:33.070>
created_at = <Date 2008-12-24.14:26:08.785>
labels = ['docs']
title = 'documentation and noddy*.c'
updated_at = <Date 2008-12-24.16:27:33.068>
user = 'https://bugs.python.org/exe'

bugs.python.org fields:

activity = <Date 2008-12-24.16:27:33.068>
actor = 'benjamin.peterson'
assignee = 'georg.brandl'
closed = True
closed_date = <Date 2008-12-24.16:27:33.070>
closer = 'benjamin.peterson'
components = ['Demos and Tools', 'Documentation']
creation = <Date 2008-12-24.14:26:08.785>
creator = 'exe'
dependencies = []
files = []
hgrepos = []
issue_num = 4737
keywords = []
message_count = 2.0
messages = ['78260', '78265']
nosy_count = 3.0
nosy_names = ['georg.brandl', 'exe', 'benjamin.peterson']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue4737'
versions = ['Python 3.0', 'Python 3.1']

Activity

  1. exe commented on Dec 24, 2008

    exemannequin
    MannequinAuthor

    Hello!

    1. In http://docs.python.org/3.0/extending/extending.html we see:
      =========
      Note that PyMODINIT_FUNC declares the function as void return type
      =========

    But thats not true, it's defined as PyObject*. I think this is outdated
    info in documentation.

    2) In Doc/includes/noddy*.c assumed that PyMODINIT_FUNC returns nothing 
    but this wrong. If you try "python3.1 -c 'import noddy'" you will see 
    segfault. This patch will fix this problem:
    --- ./noddy.c       2008-12-24 17:09:36.424870738 +0300
    +++ ./noddy.c   2008-12-24 17:18:01.524869143 +0300
    @@ -52,4 +52,6 @@
     
         Py_INCREF(&noddy_NoddyType);
         PyModule_AddObject(m, "Noddy", (PyObject *)&noddy_NoddyType);
    +
    +    return m;
     }

    Other noddy*.c files are also requiring this patch.

  2. added
    docsDocumentation in the Doc dir
    on Dec 24, 2008
  3. benjaminp commented on Dec 24, 2008

    @benjaminp
    Contributor

    Thanks for the report! Fixed in r67925.

  4. transferred this issue fromon Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

docsDocumentation in the Doc dir

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions