You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
expose _CrtSetReportMode via the msvcrt module #49366
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee='https://github.com/mhammond'closed_at=<Date2010-07-10.23:00:29.097>created_at=<Date2009-01-31.06:52:53.037>labels= ['type-feature', 'OS-windows']
title='expose _CrtSetReportMode via the msvcrt module'updated_at=<Date2010-07-10.23:00:29.096>user='https://github.com/mhammond'
In bug 4804, there is some debate about how desirable it is for Python
to unconditionally disable all CRT assertions on Windows - however,
there is agreement that exposing the ability to enable and disable these
assertions via the msvcrt module is reasonable - so I'm attaching a
patch for exactly that. I'd also like to nominate this for the 2.6 and
py3k branches.
Has there been any consensus about what to do with this? I know there
was some chatter on python-dev about assertions causing problems with
buildbots (6 months ago?) but I don't think anything came out of it.
The code change is small and looks good. Is it worth extending this to
expose CrtSetReportFile since a file is one of the options of
CrtSetReportMode?
Activity
mhammond commentedon Jan 31, 2009
In bug 4804, there is some debate about how desirable it is for Python
to unconditionally disable all CRT assertions on Windows - however,
there is agreement that exposing the ability to enable and disable these
assertions via the msvcrt module is reasonable - so I'm attaching a
patch for exactly that. I'd also like to nominate this for the 2.6 and
py3k branches.
briancurtin commentedon Dec 23, 2009
Has there been any consensus about what to do with this? I know there
was some chatter on python-dev about assertions causing problems with
buildbots (6 months ago?) but I don't think anything came out of it.
The code change is small and looks good. Is it worth extending this to
expose CrtSetReportFile since a file is one of the options of
CrtSetReportMode?
amauryfa commentedon Dec 26, 2009
_CrtSetReportMode() is exposed without the leading underscore. IMO the
_CRT_WARN and other constants should be renamed the same way.
briancurtin commentedon Dec 30, 2009
I just noticed that this already exists in py3k, added in r57823 (lacks
docs but I'll cover them in the py3k fix for bpo-7579)