Skip to content

multiprocessing: switch to autoconf detection of platform values #49795

Closed

Description

@jnoller
mannequin
BPO 5545
Nosy @tiran
Files
  • mp_autoconf.patch
  • bootstrap.sh
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2009-04-02.01:42:28.395>
    created_at = <Date 2009-03-23.17:15:02.984>
    labels = ['type-feature']
    title = 'multiprocessing: switch to autoconf detection of platform values'
    updated_at = <Date 2009-04-02.01:42:28.393>
    user = 'https://bugs.python.org/jnoller'

    bugs.python.org fields:

    activity = <Date 2009-04-02.01:42:28.393>
    actor = 'jnoller'
    assignee = 'jnoller'
    closed = True
    closed_date = <Date 2009-04-02.01:42:28.395>
    closer = 'jnoller'
    components = []
    creation = <Date 2009-03-23.17:15:02.984>
    creator = 'jnoller'
    dependencies = []
    files = ['13402', '13462']
    hgrepos = []
    issue_num = 5545
    keywords = ['patch']
    message_count = 10.0
    messages = ['84019', '84022', '84039', '84097', '84230', '84239', '84240', '84429', '85128', '85133']
    nosy_count = 3.0
    nosy_names = ['christian.heimes', 'jnoller', 'rpetrov']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'patch review'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue5545'
    versions = ['Python 3.1', 'Python 2.7']

    Activity

    1. jnoller commented on Mar 23, 2009

      jnollermannequin
      MannequinAuthor
    2. self-assigned this
      on Mar 23, 2009
    3. tiran commented on Mar 23, 2009

      @tiran
      Member

      I've correct some smaller issues and integrated the autoconf code into
      multiprocessing and setup.py A working patch is appended.

    4. rpetrov commented on Mar 23, 2009

      rpetrovmannequin
      Mannequin

      What about AC_CHECK_FUNC* macros ?

    5. tiran commented on Mar 24, 2009

      @tiran
      Member

      AC_CHECK_FUNC works only for trivial checks that do not require
      additional headers.

    6. rpetrov commented on Mar 26, 2009

      rpetrovmannequin
      Mannequin

      AC_CHECK_FUNC* check for function .
      AC_CHECK_DECL check for declaration .

      The check for functions sem_xxx() is incorrect in proposed patch. It has
      to check for function.

      I didn't review next part of the patch.

    7. tiran commented on Mar 27, 2009

      @tiran
      Member

      Dear Roumen, please do my a favor and stop throwing in random ideas and
      accusations. I appreciate any help but your replies don't help at all.
      They are just causing frustration on either side.

      I know about AC_CHECK_DECL and AC_CHECK_FUNC. As I already said I can't
      use AC_CHECK_FUNC because I can't easily include the necessary header file.
      AC_CHECK_DECL emits almost the same code as my check for sem_open and
      sem_timedwait. However I'm planing to add more sanity checks for exotic
      platforms in the future.
      My check for sem_open does exactly what it suppose to do (and exactly
      what AC_CHECK_DECL does, by the way). Why do you think it's not right?

    8. tiran commented on Mar 27, 2009

      @tiran
      Member

      Jesse, have fun with
      svn+ssh://pythondev@svn.python.org/python/branches/multiprocessing-autoconf
      during the sprint.

    9. rpetrov commented on Mar 29, 2009

      rpetrovmannequin
      Mannequin

      Cchristian it is not about random idea. It is how to write simple
      readable and correct autoconf script. Compare my check for functions
      (see attached bootstrap.sh) with you. Also some of macros in you patch
      are marked as obsolete.

      $ CC=g++ ./bootstrap.sh
      ...
      #define HAVE_SEM_OPEN 1
      #define HAVE_SEM_OPEN_XXX 0
      #define HAVE_SEM_OPEN_YYY 0
      #define HAVE_SEM_TIMEDWAIT 1
      ...

      So you propose check that fail in some cases.

    10. jnoller commented on Apr 2, 2009

      jnollermannequin
      MannequinAuthor

      This is committed as of CL 71007 on trunk.

    11. jnoller commented on Apr 2, 2009

      jnollermannequin
      MannequinAuthor

      Closing as fixed until the buildbots prove otherwise

    12. transferred this issue fromon Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    No one assigned

      Labels

      type-featureA feature request or enhancement

      Projects

      No projects

        Milestone

        No milestone

        Relationships

        None yet

        Development

        No branches or pull requests

        Issue actions