You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
test_heapq: AttributeError: 'int' object has no attribute 'pop' #53798
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee='https://github.com/pitrou'closed_at=<Date2010-08-13.22:40:21.919>created_at=<Date2010-08-13.17:31:13.897>labels= ['tests', 'type-bug', 'library']
title="test_heapq: AttributeError: 'int' object has no attribute 'pop'"updated_at=<Date2010-08-14.09:47:21.625>user='https://github.com/florentx'
This is a variant of the kind of annoyance pointed out in bpo-9548. Here, it seems addbuilddir() in Lib/site.py shouldn't import sysconfig, because it imports the re module.
florentx commented on Aug 13, 2010
florentxmannequin
MannequinAuthor
More actions
For some reason, sys.modules['heapq'] contains the Python implementation instead of the C implementation.
Tested with r83981 on python 3:
Python 3.2a1+ (py3k:83981M, Aug 13 2010, 19:02:31)
[GCC 4.3.4] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import heapq
>>> heapq.heappop(10)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/florent/dev/python/py3trunk/Lib/heapq.py", line 140, in heappop
lastelt = heap.pop() # raises appropriate IndexError if heap is empty
AttributeError: 'int' object has no attribute 'pop'
>>> import _heapq
>>> _heapq.heappop(10)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
TypeError: heap argument must be a list
These tests (TestErrorHandling) are supposed to run with the C module only.
Here is a patch which works if the patch in bpo-9548 is also applied.
It won't work alone because opening a file in text mode currently imports locale which imports re, etc. ... all before adding the build dir to sys.path.
Of course, since the logic in addbuilddir() is now much simpler, it could also be rewritten in C somewhere (where?), and the launched much earlier during the startup phase.
Activity
florentx commentedon Aug 13, 2010
Various buildbots show a failure on test_heapq.
"x86 FreeBSD 3.x" failed on revision r83882 (r83869 was OK)
http://www.python.org/dev/buildbot/all/builders/x86%20FreeBSD%203.x/builds/492
and next runs were OK, too
"PPC (Leopard|Tiger) 3.x" and "x86 Tiger 3.x" fail consistently from r83889 onwards.
all "gentoo 3.x" and "Ubuntu 3.x" fail on r83981
http://www.python.org/dev/buildbot/all/builders/x86%20gentoo%203.x/builds/2816
http://www.python.org/dev/buildbot/all/builders/x86%20Ubuntu%203.x/builds/1707
pitrou commentedon Aug 13, 2010
This is a variant of the kind of annoyance pointed out in bpo-9548. Here, it seems addbuilddir() in Lib/site.py shouldn't import sysconfig, because it imports the re module.
florentx commentedon Aug 13, 2010
For some reason, sys.modules['heapq'] contains the Python implementation instead of the C implementation.
Tested with r83981 on python 3:
Python 3.2a1+ (py3k:83981M, Aug 13 2010, 19:02:31)
[GCC 4.3.4] on linux2
Type "help", "copyright", "credits" or "license" for more information.
These tests (TestErrorHandling) are supposed to run with the C module only.
pitrou commentedon Aug 13, 2010
Here is a patch which works if the patch in bpo-9548 is also applied.
It won't work alone because opening a file in text mode currently imports locale which imports re, etc. ... all before adding the build dir to sys.path.
Of course, since the logic in addbuilddir() is now much simpler, it could also be rewritten in C somewhere (where?), and the launched much earlier during the startup phase.
pitrou commentedon Aug 13, 2010
Here is a C version of addbuilddir. It solves the present issue.
pitrou commentedon Aug 13, 2010
I've committed an updated version of the C patch in r83988, after Victor's comments on IRC.
vstinner commentedon Aug 14, 2010
r83988 is also the correct fix for bpo-586680: I updated this issue.