You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
ctypes not building under OS X because of ffi_closure_free not being defined early enough #53871
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee='https://github.com/ronaldoussoren'closed_at=<Date2010-09-16.11:35:42.682>created_at=<Date2010-08-22.20:45:22.589>labels= ['ctypes', 'build', 'release-blocker']
title='ctypes not building under OS X because of ffi_closure_free not being defined early enough'updated_at=<Date2010-09-16.11:35:42.680>user='https://github.com/brettcannon'
When I build under OS X 10.6 with LLVM I get four warnings of the type:
/Users/brett/Dev/python/3.x/scratch/Modules/_ctypes/callbacks.c:20:9: warning:
implicit declaration of function 'ffi_closure_free' is invalid in C99
[-Wimplicit-function-declaration]
ffi_closure_free(self->pcl_write);
^
They are for ffi_closure_free, ffi_closure_alloc, and ffi_prep_closure_loc.
It might as well be. OS X ships with it and is working towards making it their default compiler over gcc. Unladen also relies on it.
This compiler issue is a fairly new one (I would guess past week or so), so making sure LLVM can compile Python shouldn't be a big deal. I would have added the proper function declarations myself to fix this but I wanted to let Thomas put them where he wanted them to go.
It's not just LLVM. Building a standard OS X installer on OS X 10.5 (gcc-4.0, 10.4u SDK, i386/ppc, deployment target=10.3) or 10.6 (gcc-4.2, 10.6 SDK, i386/x86_64, dept target 10.6), _ctypes fails:
*** WARNING: renaming "_ctypes" since importing it failed: dlopen(build/lib.macosx-10.3-fat-3.2/_ctypes.so, 2): Symbol not found: _ffi_closure_alloc
One problem is that the version of libffi used on OSX is no longer in sync with the version that is used on other platforms. The version that is used on OSX does not have some of the symbols expected by ctypes, such as 'ffi_prep_closure_loc'.
Activity
brettcannon commentedon Aug 22, 2010
When I build under OS X 10.6 with LLVM I get four warnings of the type:
/Users/brett/Dev/python/3.x/scratch/Modules/_ctypes/callbacks.c:20:9: warning:
implicit declaration of function 'ffi_closure_free' is invalid in C99
[-Wimplicit-function-declaration]
ffi_closure_free(self->pcl_write);
^
They are for ffi_closure_free, ffi_closure_alloc, and ffi_prep_closure_loc.
benjaminp commentedon Aug 22, 2010
Is LLVM a supported platform?
brettcannon commentedon Aug 22, 2010
It might as well be. OS X ships with it and is working towards making it their default compiler over gcc. Unladen also relies on it.
This compiler issue is a fairly new one (I would guess past week or so), so making sure LLVM can compile Python shouldn't be a big deal. I would have added the proper function declarations myself to fix this but I wanted to let Thomas put them where he wanted them to go.
birkenfeld commentedon Sep 5, 2010
I don't think this should block 3.2a2.
+1 for supporting LLVM in general. BTW, why doesn't it build because of warnings?
ned-deily commentedon Sep 5, 2010
It's not just LLVM. Building a standard OS X installer on OS X 10.5 (gcc-4.0, 10.4u SDK, i386/ppc, deployment target=10.3) or 10.6 (gcc-4.2, 10.6 SDK, i386/x86_64, dept target 10.6), _ctypes fails:
*** WARNING: renaming "_ctypes" since importing it failed: dlopen(build/lib.macosx-10.3-fat-3.2/_ctypes.so, 2): Symbol not found: _ffi_closure_alloc
That is definitely a regression.
birkenfeld commentedon Sep 5, 2010
OK. Assigning to Ronald for now; he'll have to deal with it when building the binaries anyway.
ambv commentedon Sep 5, 2010
This was broken in r83837 with a patch for issue bpo-5504.
ronaldoussoren commentedon Sep 5, 2010
I'm looking into this issue.
One problem is that the version of libffi used on OSX is no longer in sync with the version that is used on other platforms. The version that is used on OSX does not have some of the symbols expected by ctypes, such as 'ffi_prep_closure_loc'.
ambv commentedon Sep 5, 2010
Ronald, please see bpo-5504.
ronaldoussoren commentedon Sep 5, 2010
Thanks! That patch fixes the issue for me and I will commit it later today.
ronaldoussoren commentedon Sep 5, 2010
I've committed the patch in bpo-5504 in r84535 (3.2) and that fixes this issue.
The same problem affects 2.7, I'm currently running the testsuite with the backport of this commit.
ronaldoussoren commentedon Sep 16, 2010
(Finally...) Checked in for 2.7 in r84846