You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
PyFile_FromString leaks file descriptors in python 2.7 #58710
File descriptors opened by PyFile_FromString don't get closed
when the reference count is decreased.
Correct, PyFile_FromString() doesn't close the file descriptor, even if you call its close() method. You have to call manually fclose(file->f_fp).
Or you can use PyFile_FromFile:
fp=fopen(name, mode);
if (fp==NULL) ...
obj=PyFile_FromFile(fp, name, mode, fclose);
if (obj==NULL) {
/* no need to call fclose(fp) here, it's done by PyFile_FromFile() */
...
}
...
Py_DECREF(obj);
Would you like to write a patch for the documentation?
Victor, that sounds like a strange behaviour to me.
We may change PyFile_FromString() to call fclose() when the file is
closed explicitly (call its close() method), but it may break backward
compatibility. I prefer to document the behaviour instead.
PyFile_FromString is a public API and maybe it shouldn't
have changed between 2.6 and 2.7.
PyFile_FromString() didn't change in Python 2.7.
I changed PyFile_FromFile() in Python 2.7 to fix the issue bpo-7732.
PyFile_FromFile() does also close the file if PyString_FromString() failed. It
did already close the file on fill_file_fields() error (e.g. if the file is a
directory).
Victor, what exactly are you talking about? http://hg.python.org/cpython/rev/0f5b64630fda/ *does* change PyFile_FromString.
And Matthias mentioned that the problem didn't occur with 2.6.
Activity
doko42 commentedon Apr 5, 2012
[forwarded from http://bugs.debian.org/664529]
seen with 2.7.3 rc2
File descriptors opened by PyFile_FromString don't get closed when the
reference count is decreased.
Here's my test program, pythony.c:
hello.py is 'print("hello world")'.
I'm compiling it with both Python 2.6 and 2.7.
$ gcc pythony.c -lpython2.6 -L/usr/lib/python2.6/config -I/usr/include/python2.6/ -o pythony-2.6
$ gcc pythony.c -lpython2.7 -L/usr/lib/python2.7/config -I/usr/include/python2.7/ -o pythony-2.7
The Python 2.7 version never calls close, not even at Py_Finalize().
On #d-d, jwilk suspected that this change might be the cause:
http://hg.python.org/cpython/rev/0f5b64630fda/#l4.46
vstinner commentedon Apr 5, 2012
Correct, PyFile_FromString() doesn't close the file descriptor, even if you call its close() method. You have to call manually fclose(file->f_fp).
Or you can use PyFile_FromFile:
Would you like to write a patch for the documentation?
pitrou commentedon Apr 5, 2012
Victor, that sounds like a strange behaviour to me. PyFile_FromString is a public API and maybe it shouldn't have changed between 2.6 and 2.7.
vstinner commentedon Apr 5, 2012
We may change PyFile_FromString() to call fclose() when the file is
closed explicitly (call its close() method), but it may break backward
compatibility. I prefer to document the behaviour instead.
PyFile_FromString() didn't change in Python 2.7.
I changed PyFile_FromFile() in Python 2.7 to fix the issue bpo-7732.
changeset: 72456:0f5b64630fda
branch: 2.7
parent: 72450:c02e790c4535
user: Victor Stinner <victor.stinner@haypocalc.com>
date: Fri Sep 23 19:37:03 2011 +0200
files: Doc/c-api/file.rst Lib/test/test_import.py Misc/NEWS
Objects/fileobject.c Python/import.c
description:
Issue bpo-7732: Fix a crash on importing a module if a directory has the same name
than a Python module (e.g. "__init__.py"): don't close the file twice.
PyFile_FromFile() does also close the file if PyString_FromString() failed. It
did already close the file on fill_file_fields() error (e.g. if the file is a
directory).
pitrou commentedon Apr 5, 2012
Victor, what exactly are you talking about? http://hg.python.org/cpython/rev/0f5b64630fda/ *does* change PyFile_FromString.
And Matthias mentioned that the problem didn't occur with 2.6.
python-dev commentedon Apr 5, 2012
New changeset 8258e5fa4a19 by Antoine Pitrou in branch '2.7':
Issue bpo-14505: Fix file descriptor leak when deallocating file objects created with PyFile_FromString().
http://hg.python.org/cpython/rev/8258e5fa4a19
pitrou commentedon Apr 5, 2012
Matthias, this should be fixed now.
vstinner commentedon Apr 5, 2012
Oh. I don't know (remember) why I did this change!? I suppose that I
changed it to test something and then forget to remove the temporary
hack :-/