You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee=Noneclosed_at=<Date2013-04-13.20:42:23.445>created_at=<Date2012-07-28.17:49:02.209>labels= ['type-bug', 'release-blocker']
title='Drop TYPE_INT64 from marshal in Python 3.4'updated_at=<Date2013-04-13.20:44:31.079>user='https://github.com/loewis'
So I figured I'd give this one a shot...generated a patch to remove TYPE_INT64. Tests seem to pass, but please provide any guidance if I did something wrong! Thanks.
Thank you, Daniel. The patch looks technically ok. Could you sign a contributor agreement? It will cover all your future contributions to Python: http://www.python.org/psf/contrib/
danriti commented on Apr 13, 2013
danritimannequin
Mannequin
More actions
Antoine, I just filled one out maybe 2 hours ago (I'm at a CPython sprint in Boston).
Activity
loewis commentedon Jul 28, 2012
As a follow-up of bpo-15466, TYPE_INT64 can be deleted in Python 3.4.
danriti commentedon Apr 13, 2013
So I figured I'd give this one a shot...generated a patch to remove TYPE_INT64. Tests seem to pass, but please provide any guidance if I did something wrong! Thanks.
pitrou commentedon Apr 13, 2013
Thank you, Daniel. The patch looks technically ok. Could you sign a contributor agreement? It will cover all your future contributions to Python: http://www.python.org/psf/contrib/
danriti commentedon Apr 13, 2013
Antoine, I just filled one out maybe 2 hours ago (I'm at a CPython sprint in Boston).
https://secure.echosign.com/public/viewAgreement?aid=T8FLXZG5LX3W2N&eid=T8GPRVI62IXF2Y&
pitrou commentedon Apr 13, 2013
Ah, great, thank you!
python-dev commentedon Apr 13, 2013
New changeset 74a440984b20 by Antoine Pitrou in branch 'default':
Issue bpo-15480: Remove the deprecated and unused TYPE_INT64 code from marshal.
http://hg.python.org/cpython/rev/74a440984b20
pitrou commentedon Apr 13, 2013
So, I've just tweaked the patch a bit so that ints longer than machine size are still tested for. Congrats for your first contribution!
danriti commentedon Apr 13, 2013
Looks great, thanks Antoine! =)