Skip to content

Derby: Convert the binascii module to use Argument Clinic #64350

Closed

Description

@serhiy-storchaka
BPO 20151
Nosy @larryhastings, @serhiy-storchaka
Dependencies
  • bpo-20161: inspect.signature fails on some functions which use Argument Clinic
  • bpo-20376: Argument Clinic: backslashes in docstrings are not escaped
  • Files
  • binascii_clinic.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/serhiy-storchaka'
    closed_at = <Date 2014-01-25.10:00:29.366>
    created_at = <Date 2014-01-06.19:49:08.117>
    labels = ['extension-modules', 'type-feature']
    title = 'Derby: Convert the binascii module to use Argument Clinic'
    updated_at = <Date 2014-01-25.10:00:29.364>
    user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2014-01-25.10:00:29.364>
    actor = 'serhiy.storchaka'
    assignee = 'serhiy.storchaka'
    closed = True
    closed_date = <Date 2014-01-25.10:00:29.366>
    closer = 'serhiy.storchaka'
    components = ['Extension Modules']
    creation = <Date 2014-01-06.19:49:08.117>
    creator = 'serhiy.storchaka'
    dependencies = ['20161', '20376']
    files = ['33529']
    hgrepos = []
    issue_num = 20151
    keywords = ['patch']
    message_count = 6.0
    messages = ['207473', '207596', '207628', '207647', '209173', '209180']
    nosy_count = 3.0
    nosy_names = ['larry', 'python-dev', 'serhiy.storchaka']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue20151'
    versions = ['Python 3.4']

    Activity

    1. serhiy-storchaka commented on Jan 6, 2014

      @serhiy-storchaka
      MemberAuthor

      Here is a patch which converts the binascii module to use Argument Clinic. 14 functions are converted.

      There is one known issue. Pydoc doesn't show signature and docstring for several functions: a2b_qp, b2a_qp, crc32.

    2. larryhastings commented on Jan 7, 2014

      @larryhastings
      Contributor

      Can you refresh the patch? The comments Argument Clinic uses were all changed. I'll review when you have a fresh patch.

    3. changed the title [-]Convert the binascii module to use Argument Clinic[/-] [+]Derby: Convert the binascii module to use Argument Clinic[/+] on Jan 7, 2014
    4. serhiy-storchaka commented on Jan 7, 2014

      @serhiy-storchaka
      MemberAuthor

      Here is refreshed patch.

    5. larryhastings commented on Jan 8, 2014

      @larryhastings
      Contributor

      Serhiy: Assigning to you because you wrote a patch; if you don't want the issue, sorry, please undo it.

    6. python-dev commented on Jan 25, 2014

      python-devmannequin
      Mannequin

      New changeset 21f8abfe459a by Serhiy Storchaka in branch 'default':
      Issue bpo-20151: The binascii module now uses Argument Clinic.
      http://hg.python.org/cpython/rev/21f8abfe459a

    7. python-dev commented on Jan 25, 2014

      python-devmannequin
      Mannequin

      New changeset 76a3cc6f3aca by Serhiy Storchaka in branch 'default':
      Fixed converting errors in the binascii module (bpo-20151).
      http://hg.python.org/cpython/rev/76a3cc6f3aca

    8. transferred this issue fromon Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Labels

    extension-modulesC modules in the Modules dirtype-featureA feature request or enhancement

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions