You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Cannot pickle some objects that have a __getattr__() #64460
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee='https://github.com/larryhastings'closed_at=<Date2014-02-23.07:06:32.939>created_at=<Date2014-01-14.19:46:07.118>labels= ['release-blocker', 'library', 'docs']
title='Cannot pickle some objects that have a __getattr__()'updated_at=<Date2014-02-23.07:06:32.938>user='https://github.com/warsaw'
I've been debugging a crash in nose 1.3.0, the root cause of which turned out to be an instance containing an attribute which itself was an instance of the following class (boiled down):
This crashes with a TypeError in Python 2.7 and Python 3 (albeit with slightly different tracebacks; and Python 3 is more difficult to debug because the TypeError doesn't include any useful information).
TypeError: 'NoneType' object is not callable
The culprit is __getattr__() returning None. In Python 3 for example, pickle tries to get the object's __reduce_ex__() function and then call it.
The problem is the (IMHO) bogus __getattr__() and I'm not sure why nose has this. But I wonder if the pickle documentation should warn against this kind of thing.
This isn't a bug in Python - the crash makes sense when you understand the implications, but perhaps a warning in the docs would have helped prevent this nose bug in the first place. I suppose I could also see improving _pickle.c to provide some additional feedback on the offending attribute, but that's probably more difficult.
It's okay to close this as won't fix if we can't think of appropriate wording. It's enough that there's a record of this issue for search engines now.
This is a duplicate of bpo-16251, no? Pickle looks up dunder ;) methods on instances rather than on classes, so __getattr__() gets triggered unexpectedly. I had to work around this in some code of mine by special-casing in __getattr__() names that start with '_'. I've said my peace over in bpo-16251.
Activity
warsaw commentedon Jan 14, 2014
I've been debugging a crash in nose 1.3.0, the root cause of which turned out to be an instance containing an attribute which itself was an instance of the following class (boiled down):
This crashes with a TypeError in Python 2.7 and Python 3 (albeit with slightly different tracebacks; and Python 3 is more difficult to debug because the TypeError doesn't include any useful information).
TypeError: 'NoneType' object is not callable
The culprit is __getattr__() returning None. In Python 3 for example, pickle tries to get the object's __reduce_ex__() function and then call it.
The problem is the (IMHO) bogus __getattr__() and I'm not sure why nose has this. But I wonder if the pickle documentation should warn against this kind of thing.
This isn't a bug in Python - the crash makes sense when you understand the implications, but perhaps a warning in the docs would have helped prevent this nose bug in the first place. I suppose I could also see improving _pickle.c to provide some additional feedback on the offending attribute, but that's probably more difficult.
It's okay to close this as won't fix if we can't think of appropriate wording. It's enough that there's a record of this issue for search engines now.
warsaw commentedon Jan 14, 2014
Hmm, actually, this is a regression in Python 3.4. Let's amend the test class to include a __getnewargs__():
This class is picklable in Python 2.7 - 3.3, but not in 3.4.
ericsnowcurrently commentedon Jan 15, 2014
This is a duplicate of bpo-16251, no? Pickle looks up dunder ;) methods on instances rather than on classes, so __getattr__() gets triggered unexpectedly. I had to work around this in some code of mine by special-casing in __getattr__() names that start with '_'. I've said my peace over in bpo-16251.
warsaw commentedon Jan 15, 2014
I'll go ahead and dupe this to 16251, but will note the __getnewargs__() regression in 3.4.
benjaminp commentedon Feb 16, 2014
Fixed. Should be in 3.4.0.
I'll deal with bpo-16251 in 3.5.
benjaminp commentedon Feb 16, 2014
(See http://hg.python.org/cpython/rev/b328f8ccbccf)
larryhastings commentedon Feb 23, 2014
My understanding is, this is fixed, and cherry-picked into 3.4. If that's in error please reopen.