You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee=Noneclosed_at=<Date2019-08-07.01:08:28.601>created_at=<Date2019-07-21.23:24:25.417>labels= ['type-bug', '3.7', 'docs']
title='eval() in a list comprehension'updated_at=<Date2019-08-07.01:08:28.591>user='https://bugs.python.org/GrzegorzKraso'
In Python 3, list comprehensions create their own inner scope just like generator expressions.
Per the eval() docs, "if both dictionaries are omitted, the expression is executed in the environment where eval() is called."
In your code example, the inner scope doesn't have a local variable "x", so the global variable "x" is retrieved.
That said, I would have expected the inner "x" to be found as a non-local. So yes, this does seem odd an it isn't really true that "the expression is executed in the environment where eval() is called." Instead, it uses the globals() and locals() of the environment where it is called but not the nested scope. Perhaps this should be clarified in the docs if it is in fact the intended behavior.
GrzegorzKraso commented on Jul 22, 2019
GrzegorzKrasomannequin
MannequinAuthor
More actions
Steven, I believed that any <expression> replaced by eval('<expression>') will not change behaviour of the code. Now I understand that my assumption was incorrect.
After more thought, I think the existing behavior is probably what we want. There may not be a clean way to allow access and updates to non-locals. Even if a way was found, it may tie our hands and preclude other implementation changes down the road. Also, such a feature may be at odds with the current API which allows the execution environment to be retargeted. There is also a risk of introducing new security issues.
I've attached a PR to update the eval() docs to reflect the actual behavior.
New changeset 9341dcb by Raymond Hettinger (Miss Islington (bot)) in branch '3.8': bpo-37646: Document that eval() cannot access nested scopes (GH-15117) (GH-15155) 9341dcb
Activity
GrzegorzKraso commentedon Jul 21, 2019
eval() works in a global scope when invoked in a list comprehension.
stevendaprano commentedon Jul 22, 2019
What leads you to believe that eval *shouldn't* work in the global scope in a comprehension?
If not the global scope, which scope should it be, local or nonlocal? Is the behaviour documented differently?
For reference, the current docs for eval are here:
https://docs.python.org/3.5/library/functions.html#eval
rhettinger commentedon Jul 22, 2019
This used to work as you expected in Python 2.
In Python 3, list comprehensions create their own inner scope just like generator expressions.
Per the eval() docs, "if both dictionaries are omitted, the expression is executed in the environment where eval() is called."
In your code example, the inner scope doesn't have a local variable "x", so the global variable "x" is retrieved.
That said, I would have expected the inner "x" to be found as a non-local. So yes, this does seem odd an it isn't really true that "the expression is executed in the environment where eval() is called." Instead, it uses the globals() and locals() of the environment where it is called but not the nested scope. Perhaps this should be clarified in the docs if it is in fact the intended behavior.
GrzegorzKraso commentedon Jul 22, 2019
Steven, I believed that any
<expression>replaced byeval('<expression>')will not change behaviour of the code. Now I understand that my assumption was incorrect.Raymond, thanks for helping me understand this.
stevendaprano commentedon Jul 23, 2019
I'm not sure we should be so quick to close this. At the very least, I
think the documentation could be improved.
It does seem desirable to have the invariant:
apply in any environment. Was the change in behaviour between 2 and 3
intentional, or just a side-effect of the change in implementation?
GrzegorzKraso commentedon Jul 24, 2019
I re-opened the issue.
Dear core developers, can we ask you to confirm if described behavior of eval() is expected?
rhettinger commentedon Aug 4, 2019
After more thought, I think the existing behavior is probably what we want. There may not be a clean way to allow access and updates to non-locals. Even if a way was found, it may tie our hands and preclude other implementation changes down the road. Also, such a feature may be at odds with the current API which allows the execution environment to be retargeted. There is also a risk of introducing new security issues.
I've attached a PR to update the eval() docs to reflect the actual behavior.
rhettinger commentedon Aug 7, 2019
New changeset 610a482 by Raymond Hettinger in branch 'master':
bpo-37646: Document that eval() cannot access nested scopes (GH-15117)
610a482
rhettinger commentedon Aug 7, 2019
New changeset 9341dcb by Raymond Hettinger (Miss Islington (bot)) in branch '3.8':
bpo-37646: Document that eval() cannot access nested scopes (GH-15117) (GH-15155)
9341dcb