You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
test(cli): use one terminal backend for CLI screenshots - #1747
The Termless end-to-end suite builds the npm CLI, launches its published entry point (bin/cli.js) in a real terminal, runs socket scan setup, and selects cancel. The two screenshots show the command menu and the cancellation output. They replace the old screenshots of a node -e demo.
The test uses the same xterm backend as the native CLI tests, so this removes the second backend dependency. The recorder accepts live terminal captures directly. The native binary tests still exercise scan setup, manifest setup and the TUI in their own CI step.
Run pnpm exec vitest run --config .config/vitest.terminal.config.mts to build the CLI and compare its output to the screenshots. CI runs the same command. Verified the terminal suite and snapshot refresh argument tests locally.
The npm CLI builds with the root package version. The native CLI builds with the SEA release policy, which currently selects a 2.1 release candidate. The native verifier now uses the same expected version as the builder. The release workflow test checks the npm tag for the active release line.
The macOS runner uses the existing 4 GB build heap setting for the terminal suite. The scan setup screenshot uses a wider terminal so the Windows temporary path fits before normalization. A screenshot failure prints the captured rows in the job log.
The scan reach tests that expect an invalid token use a loopback HTTP server returning 401. The analytics-disabled case checks the status and runs without a live Socket API call.
Low Risk
Test-only dependency removal and recorder API tightening with no production CLI behavior changes.
Overview
Removes the synthetic PTY Enter screenshot flow and its only consumer @termless/vterm, including lockfile entries and the deleted test/e2e/termless.test.mts. Terminal Vitest config and terminalSnapshotArgs now refresh only test/termless/utils/self-update.test.mts.
The termless animation helpers now treat captured as required on every checkpoint and createRecording assumes live captures (shared width, common trimmed height) instead of accepting bare SVG fixtures. Unit tests follow that model: optional captured? access is gone, the manual freeze/copy case is dropped, and the sequence-regression test builds recordings from two real xterm captures.
John-David Dalton (jdalton)
changed the title
Use one terminal backend for CLI screenshots
test(cli): use one terminal backend for CLI screenshots
Nov 21, 2026
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLM Description written by Codex:GPT-6
The Termless end-to-end suite builds the npm CLI, launches its published entry point (
bin/cli.js) in a real terminal, runssocket scan setup, and selects cancel. The two screenshots show the command menu and the cancellation output. They replace the old screenshots of anode -edemo.The test uses the same xterm backend as the native CLI tests, so this removes the second backend dependency. The recorder accepts live terminal captures directly. The native binary tests still exercise scan setup, manifest setup and the TUI in their own CI step.
Run
pnpm exec vitest run --config .config/vitest.terminal.config.mtsto build the CLI and compare its output to the screenshots. CI runs the same command. Verified the terminal suite and snapshot refresh argument tests locally.Follow-up to socket-mcp#241.
CI fixes
The npm CLI builds with the root package version. The native CLI builds with the SEA release policy, which currently selects a 2.1 release candidate. The native verifier now uses the same expected version as the builder. The release workflow test checks the npm tag for the active release line.
The macOS runner uses the existing 4 GB build heap setting for the terminal suite. The scan setup screenshot uses a wider terminal so the Windows temporary path fits before normalization. A screenshot failure prints the captured rows in the job log.
The scan reach tests that expect an invalid token use a loopback HTTP server returning 401. The analytics-disabled case checks the status and runs without a live Socket API call.