Closed
Labels
buildThe build process and cross-buildThe build process and cross-buildtype-featureA feature request or enhancementA feature request or enhancement
Description
| BPO | 46498 |
|---|---|
| Nosy | @loongson-zn, @xen0n |
| PRs | |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = None
created_at = <Date 2022-01-24.05:00:22.024>
labels = ['build', '3.9']
title = 'Add new triplets for loongarch64'
updated_at = <Date 2022-01-27.08:05:30.042>
user = 'https://github.com/loongson-zn'bugs.python.org fields:
activity = <Date 2022-01-27.08:05:30.042>
actor = 'loongson-zn'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Build']
creation = <Date 2022-01-24.05:00:22.024>
creator = 'loongson-zn'
dependencies = []
files = ['50579', '50590']
hgrepos = []
issue_num = 46498
keywords = ['patch']
message_count = 2.0
messages = ['411701', '411842']
nosy_count = 2.0
nosy_names = ['loongson-zn', 'xen0n']
pr_nums = ['30939']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue46498'
versions = ['Python 3.9']Metadata
Metadata
Assignees
Labels
buildThe build process and cross-buildThe build process and cross-buildtype-featureA feature request or enhancementA feature request or enhancement
Activity
xen0n commentedon Jan 26, 2022
First of all I think the changes should probably go in main branch first, then backported to the older branches if possible; although IMO you'd be much better off just backporting and carrying the patch yourselves.
Secondly the suggested patch is not consistent with the LoongArch toolchain spec, in that it didn't use the multiarch identifiers in the spec document (https://github.com/loongson/LoongArch-Documentation/blob/a8a004148734445480659a5e25ef985817881341/docs/LoongArch-toolchain-conventions-EN.adoc, Table 12), but rather the old-world one; see the discussion at loongarch64#1 (in Chinese) too.
loongson-zn commentedon Jan 27, 2022
loongarch64.diff has been modified according to the new toolchain spec.
cpython: add loongarch triplets
cpython: add loongarch triplets
corona10 commentedon May 8, 2023
I left the opinion about the issue: #30939 (comment)
[-]Add new triplets for loongarch64[/-][+]Add new triplets for 64-bit LoongArch[/+]erlend-aasland commentedon May 9, 2023
Should we also add triplets for LA32R and LA32S?
gh-90656: Add platform triplets for 64-bit LoongArch (LA64) (#30939)
erlend-aasland commentedon May 9, 2023
@xen0n, let me know if you want your attribution in the NEWS and What's New entries (IMO, it seems like that would be appropriate). We can easily patch those two files in a follow-up PR.
Merge branch 'main' into inlinecomp2
Merge branch 'main' into fixsendfamily
Merge branch 'main' into supermon
Merge branch 'main' into fixloadsuperspec