Repository navigation
gh-101283: Try to load the fallback cmd.exe by an absolute path - #101286
Conversation
commented
Jan 24, 2023
Looks like a fluke; restarting. |
Co-authored-by: Eryk Sun <eryksun@gmail.com>
Co-authored-by: Eryk Sun <eryksun@gmail.com>
commented
Jan 24, 2023
|
@eryksun Thank you for improvements! Since none of my code is left, I've reattributed the news entry to you. |
Co-authored-by: Eryk Sun <eryksun@gmail.com>
| # cmd.exe is missing, or the system environment | ||
| # variables are broken, or they're undefined and the | ||
| # system is installed into a non-standard location. | ||
| # This is highly unlikely, and we cannot help here. |
There was a problem hiding this comment.
Should a RuntimeWarning be raised or logging.warn call made in this case as an FYI?
There was a problem hiding this comment.
That's a good idea. How about this?
comspec = 'cmd.exe'
warnings.warn(f'spawning "{comspec}" using a '
'relative file path',
RuntimeWarning)There was a problem hiding this comment.
if we keep the fallback at all rather than just make it an error, something like that. probably with a stacklevel= set.
related to my other comment, i wouldn't want to add a new warning in a security backport either.
commented
Feb 8, 2023
|
Thanks @arhadthedev for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
commented
Feb 8, 2023
|
Sorry @arhadthedev and @zooba, I had trouble checking out the |
commented
Feb 8, 2023
|
Thanks @arhadthedev for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
commented
Feb 8, 2023
|
GH-101711 is a backport of this pull request to the 3.11 branch. |
commented
Feb 8, 2023
|
Bah, just noticed in the backports that now there's a case where |
commented
Feb 8, 2023
|
Turns out I can commit directly to the backports, so those will be fine. But we need an |
commented
Feb 8, 2023
|
GH-101713 is a backport of this pull request to the 3.7 branch. |
commented
Feb 8, 2023
|
GH-101712 is the comspec=executable fix for main. |
| Added the *text* parameter, as a more understandable alias of *universal_newlines*. | ||
| Added the *capture_output* parameter. | ||
|
|
||
| .. versionchanged:: 3.11.2 |
There was a problem hiding this comment.
This version number is wrong. 3.11.2 was released before this change was merged. As this PR is in the main branch, listing it as 3.12 in these docs is more appropriate. Documentation readers should not be expected to know which patch release versions came before a major release.
We lack the ability to list all versions in versionchanged markers in our docs so have done it this way elsewhere as well when a visible API change has been made in patch releases.
commented
Feb 9, 2023
Got working on it; the PR will follow in a few hours. |
commented
Feb 9, 2023
To be fixed by gh-101712. Thank you, @zooba!
Addressed in gh-101728. |
Uh oh!
There was an error while loading. Please reload this page.