Skip to content

gh-101283: Try to load the fallback cmd.exe by an absolute path - #101286

Merged
zooba merged 25 commits into
python:mainfrom
arhadthedev:absolute-cmdexe-fallback-patch
Feb 8, 2023
Merged

zooba merged 25 commits into
python:mainfrom
arhadthedev:absolute-cmdexe-fallback-patch

Conversation

@arhadthedev

@arhadthedev arhadthedev commented Jan 24, 2023 •

Copy link
Copy Markdown
Member

@arhadthedev

ghost commented Jan 24, 2023

Copy link
Copy Markdown
Member Author

PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'D:\a\cpython\cpython\build\test_python_2036�\test_python_worker_5676�'

Looks like a fluke; restarting.

@arhadthedev
arhadthedev marked this pull request as ready for review January 24, 2023 13:46
@arhadthedev
arhadthedev requested a review from gpshead as a code owner January 24, 2023 13:46
Comment thread Lib/subprocess.py Resolved
Comment thread Lib/subprocess.py Resolved
Co-authored-by: Eryk Sun <eryksun@gmail.com>
Comment thread Lib/subprocess.py Resolved
Oleg Iarygin and others added 2 commits January 24, 2023 19:48
@arhadthedev

ghost commented Jan 24, 2023

Copy link
Copy Markdown
Member Author

@eryksun Thank you for improvements! Since none of my code is left, I've reattributed the news entry to you.

Comment thread Lib/subprocess.py Resolved
Co-authored-by: Eryk Sun <eryksun@gmail.com>
@eryksun
eryksun requested a review from a team January 24, 2023 17:09
@arhadthedev
arhadthedev marked this pull request as draft January 24, 2023 18:48
@arhadthedev
arhadthedev marked this pull request as ready for review January 24, 2023 18:48
Comment thread Lib/subprocess.py Resolved
Comment thread Lib/subprocess.py Outdated
# cmd.exe is missing, or the system environment
# variables are broken, or they're undefined and the
# system is installed into a non-standard location.
# This is highly unlikely, and we cannot help here.

ghost Jan 24, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should a RuntimeWarning be raised or logging.warn call made in this case as an FYI?

ghost Jan 24, 2023 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good idea. How about this?

                        comspec = 'cmd.exe'
                        warnings.warn(f'spawning "{comspec}" using a '
                                      'relative file path',
                                      RuntimeWarning)

ghost Jan 25, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we keep the fallback at all rather than just make it an error, something like that. probably with a stacklevel= set.

related to my other comment, i wouldn't want to add a new warning in a security backport either.

@AlexWaygood AlexWaygood added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Feb 8, 2023
@miss-islington

ghost commented Feb 8, 2023

Copy link
Copy Markdown
Contributor

Thanks @arhadthedev for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington

ghost commented Feb 8, 2023

Copy link
Copy Markdown
Contributor

Sorry @arhadthedev and @zooba, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 23751ed826ee63fb486e874ec25934ea87dd8519 3.11

@AlexWaygood AlexWaygood added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Feb 8, 2023
@miss-islington

ghost commented Feb 8, 2023

Copy link
Copy Markdown
Contributor

Thanks @arhadthedev for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot

ghost commented Feb 8, 2023

Copy link
Copy Markdown

GH-101711 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Feb 8, 2023
@zooba

ghost commented Feb 8, 2023

Copy link
Copy Markdown
Member

Bah, just noticed in the backports that now there's a case where comspec may be used without being defined. We should fix and backport that immediately

@zooba

ghost commented Feb 8, 2023

Copy link
Copy Markdown
Member

Turns out I can commit directly to the backports, so those will be fine. But we need an else: comspec = executable branch in main

@bedevere-bot

ghost commented Feb 8, 2023

Copy link
Copy Markdown

GH-101713 is a backport of this pull request to the 3.7 branch.

@zooba

ghost commented Feb 8, 2023

Copy link
Copy Markdown
Member

GH-101712 is the comspec=executable fix for main.

Added the *text* parameter, as a more understandable alias of *universal_newlines*.
Added the *capture_output* parameter.

.. versionchanged:: 3.11.2

ghost Feb 8, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version number is wrong. 3.11.2 was released before this change was merged. As this PR is in the main branch, listing it as 3.12 in these docs is more appropriate. Documentation readers should not be expected to know which patch release versions came before a major release.

We lack the ability to list all versions in versionchanged markers in our docs so have done it this way elsewhere as well when a visible API change has been made in patch releases.

@arhadthedev

ghost commented Feb 9, 2023

Copy link
Copy Markdown
Member Author

Bah, just noticed in the backports that now there's a case where comspec may be used without being defined. We should fix and backport that immediately

This version number is wrong. 3.11.2 was released before this change was merged. As this PR is in the main branch, listing it as 3.12 in these docs is more appropriate. Documentation readers should not be expected to know which patch release versions came before a major release.

Got working on it; the PR will follow in a few hours.

@arhadthedev

ghost commented Feb 9, 2023

Copy link
Copy Markdown
Member Author

Bah, just noticed in the backports that now there's a case where comspec may be used without being defined. We should fix and backport that immediately

To be fixed by gh-101712. Thank you, @zooba!

This version number is wrong. 3.11.2 was released before this change was merged. As this PR is in the main branch, listing it as 3.12 in these docs is more appropriate. Documentation readers should not be expected to know which patch release versions came before a major release.

Addressed in gh-101728.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-security A security issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants